Fuse classes for wait_on tasks and input data #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leclairm
force-pushed
the
cleanup_parsing
branch
from
d4fd8d0
to
1789850
Compare
agoscinski
reviewed
Dec 2, 2024
| class _LagDateBaseModel(BaseModel): | ||
| """Base class for all classes containg a list of dates or time lags.""" | ||
| class TargetNodesBaseModel(_NamedBaseModel): | ||
| """class for targetting other task or data nodes in the graph""" |
There was a problem hiding this comment.
Can you explain this a bit more in the docstring? Reading it, it is not so clear for me
There was a problem hiding this comment.
Maybe something like this. But I am also not really happy with this
Suggested change
| """class for targetting other task or data nodes in the graph""" | |
| """Class for specifying time information relative to the cycle date, and | |
| information related to the parametrization. """ |
I hope when we move to a release it becomes clearer how to describe this class.
agoscinski
approved these changes
Dec 2, 2024
leclairm
force-pushed
the
cleanup_parsing
branch
from
1789850
to
317243e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fuse classes for wait_on tasks and input data as they use the exact same keywords for the same purpose, namely targeting other nodes when building the graph.
Also reorder the classes in
_yaml_data_models.pyso that they correspond more to the order in the exampleyamlfiles (even though this order is just a convention and can be changed by the users without consequences)