Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes pygraphviz failure when building wheels #58

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

agoscinski
Copy link
Collaborator

One needs to install graphviz over the system package manager before installing pygraphviz to prevent an automatic build that fails. This can is achieved widh sudo apt-get install graphviz graphviz-dev.

We also add the workflow_dispatch event so we can run the workflow manually.

@agoscinski agoscinski force-pushed the fix/pygraphviz-wheel-failure branch 5 times, most recently from 60754c0 to 14dd735 Compare December 2, 2024 13:48
@agoscinski
Copy link
Collaborator Author

agoscinski commented Dec 2, 2024

I think workflow_dispatch starts working when merged, right now I cannot run it manually and did it by temporary changing the trigger to happen on a push to any branch (see run that worked https://github.com/C2SM/Sirocco/actions/runs/12120979713)

@agoscinski agoscinski force-pushed the fix/pygraphviz-wheel-failure branch 2 times, most recently from 75b4806 to f27707b Compare December 2, 2024 14:04
One needs to install graphviz over the system package manager before
installing pygraphviz to prevent an automatic build that fails. This can
is achieved with `sudo apt-get install graphviz graphviz-dev`.

The `--force` was in `hatch run docs:deploy --force` was ignored. hatch
does not support arguments so we directly use it in the hatch-script
definition. Replacing `--force` to ``--no-history`.`
See pypa/hatch#988

We also add the `workflow_dispatch` event so we can run the workflow
manually.
Copy link
Contributor

@leclairm leclairm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I blindly trust you on this! 😉

@agoscinski agoscinski merged commit 602c3fe into main Dec 3, 2024
3 checks passed
@agoscinski agoscinski deleted the fix/pygraphviz-wheel-failure branch December 3, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants