Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Halo exchanges nh solve #302

Merged
merged 26 commits into from
Nov 8, 2023
Merged

Halo exchanges nh solve #302

merged 26 commits into from
Nov 8, 2023

Conversation

halungge
Copy link
Contributor

@halungge halungge commented Oct 25, 2023 •
edited
Loading

Add halo exchanges to solve non hydro.

  • introduce a convenience (blocking) exchange function in ExchangeRuntime
  • introduce the halo exhange call in SolveNonHydro
  • fix horizontal domains in SolveNonHydro Stencils 66 to 68
  • adds a new test case for the SolveNonHydro.time_step that is run in parallel
  • fix the MPI tear down problem at the end of a MPI test run

in single node SolveNonHydro test:

  • remove the indices upper indices in fields assertions where they correspond to the fieldsize

@halungge
add exchange to solve_nonydro.py
7c19efd
@halungge
add convenience method exchange_and_wait in protocol
132adef
@halungge
Merge branch 'main' into halo_exchanges_nh_solve
a1bc2bf
@halungge
Merge branch 'main' into halo_exchanges_nh_solve
5129040
@halungge
remove SimpleMesh from test_solve_nonhydro.py
9fe8035
@halungge
merge main
2bd2c24
@halungge
predictor test: extract domain boundaries for Cells, remove total size
4b91541
@halungge
predictor test: extract domain boundaries for Edges remove total size,
5b2e343
@halungge
add test for parallel
15f3555 
solve_nonydro.py::timestep
@halungge
remove fields not registered in the savepoint
6321026
@halungge
WIP parallel tests
f71d08a
@halungge
split istep_init, istep_exit, jstep_init/jstep_exit make single node …
3474aeb 
…version pass
@halungge
fix theta_v and exner calculation on halo cells in nh_solve, remove u…
8419e58 
…nnecessary domain bounds on stencil_66
@halungge
pre-commit
80d99d7
@halungge
- update data urls
3dd6416
@halungge
remove obsolete parametrization on processor_props fixture
0477384 
add pytest cleanup that properly finalizes MPI
@halungge
fix licence header
6f8d3a0
@halungge
Copy link
Contributor Author

cscs-ci run

@halungge halungge marked this pull request as ready for review October 26, 2023 11:30
@halungge
Copy link
Contributor Author

launch jenkins spack

@halungge
Copy link
Contributor Author

cscs-ci run

@halungge
Copy link
Contributor Author

launch jenkins spack

@halungge
Copy link
Contributor Author

halungge commented Nov 1, 2023

cscs-ci run

@halungge
Copy link
Contributor Author

halungge commented Nov 1, 2023

launch jenkins spack

@halungge
Copy link
Contributor Author

halungge commented Nov 7, 2023

cscs-ci run

@halungge
Copy link
Contributor Author

halungge commented Nov 7, 2023

launch jenkins spack

@halungge
Copy link
Contributor Author

halungge commented Nov 8, 2023

cscs-ci run

@halungge
Copy link
Contributor Author

halungge commented Nov 8, 2023

launch jenkins spack

@halungge
Copy link
Contributor Author

halungge commented Nov 8, 2023

cscs-ci run

@halungge
Copy link
Contributor Author

halungge commented Nov 8, 2023

launch jenkins spack

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2023

Mandatory Tests

Please make sure you run these tests via comment before you merge!

  • cscs-ci run
  • launch jenkins spack

Optional Tests

In case your change might affect downstream icon-exclaim, please consider running

  • launch jenkins icon

For more detailed information please look at CI in the EXCLAIM universe.

@halungge
Copy link
Contributor Author

halungge commented Nov 8, 2023

cscs-ci run

@halungge
Copy link
Contributor Author

halungge commented Nov 8, 2023

launch jenkins spack

@halungge halungge merged commit d2ae0e5 into main Nov 8, 2023
5 checks passed
@halungge halungge deleted the halo_exchanges_nh_solve branch November 8, 2023 13:20
@halungge halungge restored the halo_exchanges_nh_solve branch November 8, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfarabullini nfarabullini nfarabullini approved these changes

@abishekg7 abishekg7 Awaiting requested review from abishekg7

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@halungge @nfarabullini