Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add noqa A004 for imports of gt4py-builtins abs #309

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

halungge
Copy link
Contributor

@halungge halungge commented Nov 7, 2023

Fixes the failure in the QA actions:

  • add #noqa where gt4py.next.ffront.fbuiltins.abs is imported
  • force yesqa to use flake8-builtins==2.2.0 version in .pre-commit-config.yaml

Copy link

github-actions bot commented Nov 7, 2023

Mandatory Tests

Please make sure you run these tests via comment before you merge!

  • cscs-ci run
  • launch jenkins spack

Optional Tests

In case your change might affect downstream icon-exclaim, please consider running

  • launch jenkins icon

For more detailed information please look at CI in the EXCLAIM universe.

@halungge
Copy link
Contributor Author

halungge commented Nov 7, 2023

cscs-ci run

@halungge
Copy link
Contributor Author

halungge commented Nov 7, 2023

launch jenkins spack

@halungge halungge marked this pull request as ready for review November 8, 2023 08:16
@halungge halungge merged commit 2686dc1 into main Nov 8, 2023
5 checks passed
@halungge halungge deleted the fix_precommit_flake8_builtin branch November 8, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants