-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for new gt4py default backend #318
Conversation
cscs-ci run |
launch jenkins spack |
This change will make it difficult to test and integrate different backends (for example the @havogt Do we expect the Another solution is to change the default backend for all tests (currently |
The backend in the Otherwise fixing the to |
Ok I'll submit the change of the Update: the problem of the spack tests would still remain because spack retrieves its own gt4py version in its environment file. Thus this still won't unlock icon4py main. Moreover the cluster used for the testing is also included in the maintenance day and no test run. |
cscs-ci run |
launch jenkins spack |
- switch to as_field from deprecates np_as_located_field - use asnumpy() instead of np.asarray()
- use asnumpy() to convert to numpy array
cscs-ci run |
cscs-ci run |
cscs-ci run |
launch jenkins spack |
cscs-ci run |
launch jenkins spack |
…ion which needs to be understood better
preliminary ignore of failing predictor and single step test.
…x_tests_advection
cscs-ci run |
launch jenkins spack |
model/atmosphere/advection/tests/stencil_tests/test_divide_flux_area_list_stencil_02.py
Outdated
Show resolved
Hide resolved
model/atmosphere/diffusion/src/icon4py/model/atmosphere/diffusion/diffusion.py
Show resolved
Hide resolved
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests In case your change might affect downstream icon-exclaim, please consider running
For more detailed information please look at CI in the EXCLAIM universe. |
cscs-ci run |
launch jenkins spack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me. Although all these .asnumpy
calls are a bit ugly.. Will we also use the StencilTest
infrastructure here at some point? In that way we could hide the asnumpy
calls in the future.
This PR fixes the multiple tests failing after recent commits in
gt4py
:roundtrip
) one.2.1
np.asarray(<field>)
are replaced by<field>.asnumpy()
2.2
as_1D_sparse_field()
are replaced bynumpy_to_1D_sparse_field()
2.3
StridedNeighborOffsetProvider()
are replaced bygrid.get_offset_provider()
2.4
np_as_located_field()
are replaced byas_field(.., data=...)