Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[py2fgen]: support for Fortran granules #402

Merged
merged 64 commits into from
Apr 12, 2024
Merged

[py2fgen]: support for Fortran granules #402

merged 64 commits into from
Apr 12, 2024

Conversation

samkellerhals
Copy link
Contributor

@samkellerhals samkellerhals commented Feb 29, 2024 •
edited
Loading

Description

Progress:

  • Enabled support for GT4Py backends on both CPU and GPU.
  • Automated generation of all necessary bindings to embed Python functions and GT4Py programs into Fortran.

ICON Integration:

  • Successfully integrated Python diffusion module into ICON-DSL CPU and GPU (OpenACC) build.

Next Steps

  • Benchmarking and timing performance on single and multi node (CPU, GPU).

    • Identify bottlenecks.

  • Test the output of the diffusion granule, can check against serialized data.

  • Document the build process (integration into ICON) and improve it, identify potential issues.

@samkellerhals
Copy link
Contributor Author

cscs-ci run default

@samkellerhals
Copy link
Contributor Author

cscs-ci run default

@samkellerhals
Add diffusion test case with serialized data
06209d5
@samkellerhals
Add run_diffusion_model driver
a2be419
@samkellerhals
Add edge and cell geometry args to dummy diffusion driver
d13629a
@samkellerhals
Merge branch 'main' of github.com:C2SM/icon4py into run-granule-with-…
355a402 
…py2fgen
@samkellerhals
Python dummy driver for diffusion wrapper
7be6eeb
@samkellerhals
Support exposing multiple functions
bef7877
@samkellerhals
test compilation with multiple embedded functions
e75ded8
@samkellerhals
Cleanup generated subroutine names
7b59d7c
@samkellerhals
Compile and run diffusion granule from Fortran driver
8ed37ea
@samkellerhals
Run diffusion twice in unit test, and remove debug flag
3a8b58a
@samkellerhals
Expand codegen tests
c96a341
@samkellerhals
Add CFFI integration test
5b37966
@samkellerhals
cleanup fstring
6c3b690
@samkellerhals
Return exit code from embedded Python function
1fb335f
@samkellerhals
Remove call.py
4ee9c1d
@samkellerhals
Reproduce boolean memory repr error
a13343d
@samkellerhals
convert boolean integer arrays to numpy bool types at runtime
3ab48b3
@samkellerhals
add missing type hint
36a013f
@samkellerhals
Use chia rui's diffusion
9955a07
@samkellerhals
Update diffusion wrapper
782db41
@samkellerhals
Use log file for debug and exception information
2a72fbf
@samkellerhals
Run granule on gpu (#413)
1f1a5ba 
add preliminary gpu support
@samkellerhals
Experiments with Fortran to Python GPU interoperability (#415)
2a82047 
Add GPU support
@samkellerhals
pull from main, fix conflicts
e0a0a8f
@samkellerhals
Fix py2f tests
8649317
@samkellerhals
Copy link
Contributor Author

cscs-ci run default

@samkellerhals
Copy link
Contributor Author

cscs-ci run default

@samkellerhals
Copy link
Contributor Author

cscs-ci run default

@samkellerhals
Copy link
Contributor Author

launch jenkins spack

@samkellerhals
Copy link
Contributor Author

cscs-ci run default

@samkellerhals
Copy link
Contributor Author

cscs-ci run default

@samkellerhals
Copy link
Contributor Author

cscs-ci run default

@samkellerhals
Copy link
Contributor Author

launch jenkins spack

@samkellerhals
Copy link
Contributor Author

cscs-ci run default

@samkellerhals
Copy link
Contributor Author

launch jenkins spack

@samkellerhals
Copy link
Contributor Author

cscs-ci run default

@samkellerhals
Copy link
Contributor Author

launch jenkins spack

halungge
halungge approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@halungge halungge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one small thing:
Do you need the change of dtype ( int32-> int) in vertical.py. If not can you revert it back to int32?

I'll approve anyway.

model/common/src/icon4py/model/common/grid/vertical.py Outdated Show resolved Hide resolved
model/common/src/icon4py/model/common/grid/vertical.py Outdated Show resolved Hide resolved
model/common/src/icon4py/model/common/settings.py Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Mandatory Tests

Please make sure you run these tests via comment before you merge!

  • cscs-ci run default
  • launch jenkins spack

Optional Tests

To run benchmarks you can use:

  • cscs-ci run benchmark

To run tests and benchmarks with the DaCe backend you can use:

  • cscs-ci run dace

In case your change might affect downstream icon-exclaim, please consider running

  • launch jenkins icon

For more detailed information please look at CI in the EXCLAIM universe.

@samkellerhals
Copy link
Contributor Author

cscs-ci run default

@samkellerhals
Copy link
Contributor Author

launch jenkins spack

@samkellerhals samkellerhals merged commit 6f6a460 into main Apr 12, 2024
5 checks passed
@samkellerhals samkellerhals deleted the run-granule-with-py2fgen branch April 12, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halungge halungge halungge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samkellerhals @halungge @abishekg7