Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Py2F]: Enable Py2F GPU tests on CI #471

Merged
merged 89 commits into from
Jun 18, 2024
Merged

[Py2F]: Enable Py2F GPU tests on CI #471

merged 89 commits into from
Jun 18, 2024

Conversation

samkellerhals
Copy link
Contributor

@samkellerhals samkellerhals commented May 28, 2024 •
edited
Loading

Adds integration tests for testing python granules running on GPU.

  • Modifies Dockerfile to make NVHPC toolkit available to compile OpenACC codes in Fortran integration tests.
  • GPU Integration test for the diffusion granule and simple square wrapper.

samkellerhals and others added 30 commits April 12, 2024 14:04
@samkellerhals
Add cProfile to wrapper
6284fab
@samkellerhals
Add CachedProgram
ec54515
@samkellerhals
Conditionally generate host_data
8bcca18
@samkellerhals
more acc fixes
a5241bf
@samkellerhals
Use CachedProgram in diffusion
03e4045
@samkellerhals
remove cached program
7e21089
@samkellerhals
Add cached programs and duplicate one program
e6b453f
@samkellerhals
Load connectivities on device in Grid
47be422
@samkellerhals
use math.prod in unpacking functions
a55c509
@samkellerhals
Merge branch 'main' of github.com:C2SM/icon4py into py2f-with-optimis…
0b7afb5 
…ations
@samkellerhals
Py2f cachedprogram fixes (#452)
17fc611 
* Remove optimisations

* Correctly pass sizes to bindings

* Convert all granule stencils to CachedProgram
@samkellerhals
Merge branch 'py2f-with-optimisations' of github.com:C2SM/icon4py int…
ae733b1 
…o py2f-with-optimisations
@samkellerhals
Add multi_return profiling test
b06ee35
@halungge
fix import of roundtrip
53dda46
@halungge
temporarily removing sudo apt update
d0995e5
@halungge
temporarily removing sudo apt update
e133e75
@samkellerhals
cleanup diffusion.py
6c81409
@samkellerhals
cleanup diffusion.py
18fab84
@samkellerhals
remove conflict
fbdcd07
@halungge
udno - temporarily removing sudo apt update
bfe3b19
@halungge @havogt
Update model/common/src/icon4py/model/common/config.py
f105880 
Co-authored-by: Hannes Vogt <[email protected]>
@halungge
fix import
2a1345d
@halungge
fix import
c8660c5
@halungge
fix import
dffdbc3
@samkellerhals
fix import in template.py
eb40203
@samkellerhals
Merge branch 'fix_roundtrip_import' of github.com:C2SM/icon4py into f…
c272075 
…ix_roundtrip_import
@samkellerhals
Merge branch 'fix_roundtrip_import' of github.com:C2SM/icon4py into p…
6be6136 
…y2f-with-optimisations
@samkellerhals
Merge branch 'main' of github.com:C2SM/icon4py into py2f-with-optimis…
82515de 
…ations
@samkellerhals
Pass cached connectivities
06d2a04
@samkellerhals
Remove isinstance checks from size passing
ffb27c6
@samkellerhals
Copy link
Contributor Author

cscs-ci run default

@samkellerhals
Copy link
Contributor Author

cscs-ci run default

@samkellerhals
Copy link
Contributor Author

cscs-ci run default

@samkellerhals
Copy link
Contributor Author

cscs-ci run default

@samkellerhals
Copy link
Contributor Author

cscs-ci run default

@samkellerhals
Copy link
Contributor Author

cscs-ci run default

@samkellerhals
Copy link
Contributor Author

cscs-ci run default

@samkellerhals
Copy link
Contributor Author

cscs-ci run default

@samkellerhals
Copy link
Contributor Author

cscs-ci run default

@samkellerhals
Copy link
Contributor Author

cscs-ci run default

@github-actions GitHub Actions
Copy link

Mandatory Tests

Please make sure you run these tests via comment before you merge!

  • cscs-ci run default
  • launch jenkins spack

Optional Tests

To run benchmarks you can use:

  • cscs-ci run benchmark

To run tests and benchmarks with the DaCe backend you can use:

  • cscs-ci run dace

In case your change might affect downstream icon-exclaim, please consider running

  • launch jenkins icon

For more detailed information please look at CI in the EXCLAIM universe.

@samkellerhals
Copy link
Contributor Author

cscs-ci run default

@samkellerhals
Copy link
Contributor Author

launch jenkins spack

abishekg7
abishekg7 approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@abishekg7 abishekg7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@samkellerhals samkellerhals merged commit 8cb8ee7 into main Jun 18, 2024
5 checks passed
@samkellerhals samkellerhals deleted the extend-py2f-ci branch June 18, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abishekg7 abishekg7 abishekg7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samkellerhals @abishekg7 @halungge