-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metrics fields factory #535
base: main
Are you sure you want to change the base?
Conversation
fix vertical dimension in z_mc
allow factory to be instantiated without backend, and grid
fix type annotations for np.ndarray in compute_zdiff_gradp_dsl.py and compute_diffusion_metrics.py
…on4py into metrics_fields_factory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not review everything, but added a couple of comments, which you could fix.
For the metrics factory itself, and the metrics field stencil computations. There are a couple of them that we should fuse/inline such that in the factory only the fields that are really used in the model are registered. So all the fields that are local fields in mo_vertical_grid.f90
we should inline in the stencil functions that use them: for example
z_aux2
, z_ifv
, z_me
. In most cases that should work. There might remain one or two where the combination which are done separately because of missing gt4py support.
model/common/src/icon4py/model/common/metrics/metrics_factory.py
Outdated
Show resolved
Hide resolved
model/common/src/icon4py/model/common/metrics/metrics_factory.py
Outdated
Show resolved
Hide resolved
model/common/src/icon4py/model/common/metrics/metrics_factory.py
Outdated
Show resolved
Hide resolved
model/common/src/icon4py/model/common/metrics/metrics_factory.py
Outdated
Show resolved
Hide resolved
model/common/src/icon4py/model/common/metrics/metrics_factory.py
Outdated
Show resolved
Hide resolved
…on4py into metrics_fields_factory
cscs-ci run default |
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
To run tests and benchmarks with the DaCe backend you can use:
In case your change might affect downstream icon-exclaim, please consider running
For more detailed information please look at CI in the EXCLAIM universe. |
Implementation of metrics fields wrt new factory format