Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics fields factory #535

Open
wants to merge 120 commits into
base: main
Choose a base branch
from
Open

Metrics fields factory #535

wants to merge 120 commits into from

Conversation

nfarabullini
Copy link
Contributor

@nfarabullini nfarabullini commented Aug 29, 2024

Implementation of metrics fields wrt new factory format

halungge and others added 30 commits June 27, 2024 11:25
fix vertical dimension in z_mc
allow factory to be instantiated without backend, and grid
fix type annotations for np.ndarray in compute_zdiff_gradp_dsl.py and compute_diffusion_metrics.py
Copy link
Contributor

@halungge halungge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not review everything, but added a couple of comments, which you could fix.

For the metrics factory itself, and the metrics field stencil computations. There are a couple of them that we should fuse/inline such that in the factory only the fields that are really used in the model are registered. So all the fields that are local fields in mo_vertical_grid.f90 we should inline in the stencil functions that use them: for example
z_aux2, z_ifv, z_me . In most cases that should work. There might remain one or two where the combination which are done separately because of missing gt4py support.

model/common/src/icon4py/model/common/grid/vertical.py Outdated Show resolved Hide resolved
model/common/src/icon4py/model/common/grid/vertical.py Outdated Show resolved Hide resolved
model/common/src/icon4py/model/common/states/factory.py Outdated Show resolved Hide resolved
@nfarabullini nfarabullini changed the base branch from prototype_fields_factory to main November 29, 2024 12:49
@nfarabullini
Copy link
Contributor Author

cscs-ci run default

Copy link

Mandatory Tests

Please make sure you run these tests via comment before you merge!

  • cscs-ci run default
  • launch jenkins spack

Optional Tests

To run benchmarks you can use:

  • cscs-ci run benchmark

To run tests and benchmarks with the DaCe backend you can use:

  • cscs-ci run dace

In case your change might affect downstream icon-exclaim, please consider running

  • launch jenkins icon

For more detailed information please look at CI in the EXCLAIM universe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants