Skip to content

Commit

Permalink
[Cypress] Transaction details tests fix (elastic#199391)
Browse files Browse the repository at this point in the history
## Summary
This PR re-enables the Transaction details cypress test, which was
disabled due to flakiness. The majority of the tests in this file needed
an increased timeout to run correctly. However, the 'Show top errors
table' test remains disabled, because it will consistently fail in
buildkite executing `.contains('a', '[MockError] Foo')`. This is
unreproducible locally, and no amount of refactoring or re-configuring
seems to affect the outcome.

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
  • Loading branch information
bryce-b authored and CAWilson94 committed Dec 9, 2024
1 parent b78e873 commit 1665d16
Showing 1 changed file with 6 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@ const timeRange = {
rangeFrom: start,
rangeTo: end,
};
// flaky
describe.skip('Transaction details', () => {
describe('Transaction details', () => {
before(() => {
synthtrace.index(
opbeans({
Expand All @@ -34,7 +33,7 @@ describe.skip('Transaction details', () => {
cy.loginAsViewerUser();
});

it('shows transaction name and transaction charts', () => {
it('shows transaction name and transaction charts', { defaultCommandTimeout: 60000 }, () => {
cy.intercept('GET', '/internal/apm/services/opbeans-java/transactions/charts/latency?*').as(
'transactionLatencyRequest'
);
Expand All @@ -60,7 +59,7 @@ describe.skip('Transaction details', () => {
'@transactionThroughputRequest',
'@transactionFailureRateRequest',
],
{ timeout: 30000 }
{ timeout: 60000 }
).spread((latencyInterception, throughputInterception, failureRateInterception) => {
expect(latencyInterception.request.query.transactionName).to.be.eql('GET /api/product');

Expand Down Expand Up @@ -106,7 +105,9 @@ describe.skip('Transaction details', () => {
);
cy.contains('Create SLO');
});
it('shows top errors table', () => {

// flaky
it.skip('shows top errors table', () => {
cy.visitKibana(
`/app/apm/services/opbeans-java/transactions/view?${new URLSearchParams({
...timeRange,
Expand Down

0 comments on commit 1665d16

Please sign in to comment.