Skip to content

Commit

Permalink
[Search] Web crawler name consistency (elastic#202738)
Browse files Browse the repository at this point in the history
## Summary

This PR fixes the areas where we display the Web Crawler naming bearing
in mind these agreements :
- We should be capitalizing when referring to the product name: Elastic
Web Crawler / Web Crawler /Elastic Open Web Crawler
- We can use lower case when referring to the feature or concept of web
crawler( crawler in short): "Use the web crawler to ..."

ESS:
![CleanShot 2024-12-03 at 15 19
19@2x](https://github.com/user-attachments/assets/d5cba886-09b3-4c34-b6e5-565cb67b9e08)

ES3:
![CleanShot 2024-12-03 at 15 19
56@2x](https://github.com/user-attachments/assets/2a6b6a8a-697c-4001-96d8-c826b6769836)


Notes: Also fixing buttons that take users to the Open Web Crawler repo
to open the links in a new tab and don't lose the product focus.
  • Loading branch information
JoseLuisGJ authored and CAWilson94 committed Dec 12, 2024
1 parent c635831 commit 5d98e40
Show file tree
Hide file tree
Showing 14 changed files with 18 additions and 16 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export const connectorsBreadcrumbs = [

export const crawlersBreadcrumbs = [
i18n.translate('xpack.enterpriseSearch.content.crawlers.breadcrumb', {
defaultMessage: 'Web crawlers',
defaultMessage: 'Web Crawlers',
}),
];

Expand Down Expand Up @@ -93,7 +93,7 @@ export const Connectors: React.FC<ConnectorsProps> = ({ isCrawler }) => {
defaultMessage: 'Elasticsearch connectors',
})
: i18n.translate('xpack.enterpriseSearch.crawlers.title', {
defaultMessage: 'Elasticsearch web crawlers',
defaultMessage: 'Elastic Web Crawler',
}),
rightSideGroupProps: {
gutterSize: 's',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ export const CrawlerEmptyState: React.FC = () => {
fill
iconType={GithubIcon}
href={'https://github.com/elastic/crawler'}
target="_blank"
>
{i18n.translate(
'xpack.enterpriseSearch.crawlerEmptyState.openSourceCrawlerButtonLabel',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ export const NewSearchIndexTemplate: React.FC<Props> = ({
{i18n.translate(
'xpack.enterpriseSearch.content.newIndex.newSearchIndexTemplate.learnMoreCrawler.linkText',
{
defaultMessage: 'Learn more about the Elastic web crawler',
defaultMessage: 'Learn more about the Elastic Web Crawler',
}
)}
</EuiLink>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ describe('generateSideNavItems', () => {
},
'enterpriseSearchContent:webCrawlers': {
id: 'enterpriseSearchContent:webCrawlers',
title: 'Web crawlers',
title: 'Web Crawlers',
url: '/app/enterprise_search/content/crawlers',
},
} as unknown as Record<string, ChromeNavLink | undefined>;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ const baseNavItems = [
href: '/app/enterprise_search/content/crawlers',
id: 'crawlers',
items: undefined,
name: 'Web crawlers',
name: 'Web Crawlers',
},
],
name: 'Content',
Expand Down Expand Up @@ -184,7 +184,7 @@ const mockNavLinks = [
},
{
id: 'enterpriseSearchContent:webCrawlers',
title: 'Web crawlers',
title: 'Web Crawlers',
url: '/app/enterprise_search/content/crawlers',
},
{
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/enterprise_search/public/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ const contentLinks: AppDeepLink[] = [
id: 'webCrawlers',
path: `/${CRAWLERS_PATH}`,
title: i18n.translate('xpack.enterpriseSearch.navigation.contentWebcrawlersLinkLabel', {
defaultMessage: 'Web crawlers',
defaultMessage: 'Web Crawlers',
}),
},
];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ describe('classicNavigationFactory', function () {
},
{
id: 'enterpriseSearchContent:webCrawlers',
title: 'Web crawlers',
title: 'Web Crawlers',
url: '/app/enterprise_search/content/crawlers',
},
];
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/serverless_search/common/i18n_string.ts
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export const CONNECTOR_LABEL: string = i18n.translate('xpack.serverlessSearch.co
export const WEB_CRAWLERS_LABEL: string = i18n.translate(
'xpack.serverlessSearch.webCrawlersLabel',
{
defaultMessage: 'Web crawlers',
defaultMessage: 'Web Crawlers',
}
);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,7 @@ export const EmptyWebCrawlersPrompt: React.FC = () => {
fill
iconType={githubIcon}
href={'https://github.com/elastic/crawler'}
target="_blank"
>
{i18n.translate('xpack.serverlessSearch.webCrawlersEmpty.selfManagedButton', {
defaultMessage: 'Self-managed web crawler',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export const WebCrawlersElasticManaged = () => {
<EuiPageTemplate offset={0} grow restrictWidth data-test-subj="svlSearchConnectorsPage">
<EuiPageTemplate.Header
pageTitle={i18n.translate('xpack.serverlessSearch.webcrawlers.title', {
defaultMessage: 'Web crawlers',
defaultMessage: 'Web Crawlers',
})}
data-test-subj="serverlessSearchConnectorsTitle"
restrictWidth
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export const WebCrawlersOverview = () => {
<EuiPageTemplate offset={0} grow restrictWidth data-test-subj="svlSearchConnectorsPage">
<EuiPageTemplate.Header
pageTitle={i18n.translate('xpack.serverlessSearch.webcrawlers.title', {
defaultMessage: 'Web crawlers',
defaultMessage: 'Web Crawlers',
})}
data-test-subj="serverlessSearchConnectorsTitle"
restrictWidth
Expand Down
4 changes: 2 additions & 2 deletions x-pack/test/functional_search/tests/classic_navigation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export default function searchSolutionNavigation({
{ id: 'Content', label: 'Content' },
{ id: 'Indices', label: 'Indices' },
{ id: 'Connectors', label: 'Connectors' },
{ id: 'Crawlers', label: 'Web crawlers' },
{ id: 'Crawlers', label: 'Web Crawlers' },
{ id: 'Build', label: 'Build' },
{ id: 'Playground', label: 'Playground' },
{ id: 'SearchApplications', label: 'Search Applications' },
Expand Down Expand Up @@ -76,7 +76,7 @@ export default function searchSolutionNavigation({
await searchClassicNavigation.clickNavItem('Crawlers');
await searchClassicNavigation.expectNavItemActive('Crawlers');
await searchClassicNavigation.breadcrumbs.expectBreadcrumbExists('Content');
await searchClassicNavigation.breadcrumbs.expectBreadcrumbExists('Web crawlers');
await searchClassicNavigation.breadcrumbs.expectBreadcrumbExists('Web Crawlers');

// Check Build
// > Playground
Expand Down
4 changes: 2 additions & 2 deletions x-pack/test/functional_search/tests/solution_navigation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export default function searchSolutionNavigation({
await solutionNavigation.sidenav.expectLinkExists({ text: 'Dashboards' });
await solutionNavigation.sidenav.expectLinkExists({ text: 'Indices' });
await solutionNavigation.sidenav.expectLinkExists({ text: 'Connectors' });
await solutionNavigation.sidenav.expectLinkExists({ text: 'Web crawlers' });
await solutionNavigation.sidenav.expectLinkExists({ text: 'Web Crawlers' });
await solutionNavigation.sidenav.expectLinkExists({ text: 'Playground' });
await solutionNavigation.sidenav.expectLinkExists({ text: 'Search applications' });
await solutionNavigation.sidenav.expectLinkExists({ text: 'Behavioral Analytics' });
Expand Down Expand Up @@ -147,7 +147,7 @@ export default function searchSolutionNavigation({
deepLinkId: 'enterpriseSearchContent:webCrawlers',
});
await solutionNavigation.breadcrumbs.expectBreadcrumbExists({ text: 'Content' });
await solutionNavigation.breadcrumbs.expectBreadcrumbExists({ text: 'Web crawlers' });
await solutionNavigation.breadcrumbs.expectBreadcrumbExists({ text: 'Web Crawlers' });
await solutionNavigation.breadcrumbs.expectBreadcrumbExists({
deepLinkId: 'enterpriseSearchContent:webCrawlers',
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ export default function ({ getPageObject, getService }: FtrProviderContext) {
await solutionNavigation.sidenav.expectLinkExists({ text: 'Data' });
await solutionNavigation.sidenav.expectLinkExists({ text: 'Index Management' });
await solutionNavigation.sidenav.expectLinkExists({ text: 'Connectors' });
await solutionNavigation.sidenav.expectLinkExists({ text: 'Web crawlers' });
await solutionNavigation.sidenav.expectLinkExists({ text: 'Web Crawlers' });
await solutionNavigation.sidenav.expectLinkExists({ text: 'Build' });
await solutionNavigation.sidenav.expectLinkExists({ text: 'Dev Tools' });
await solutionNavigation.sidenav.expectLinkExists({ text: 'Playground' });
Expand Down

0 comments on commit 5d98e40

Please sign in to comment.