Skip to content

Commit

Permalink
fix: [Search:AppSearch:Engines:Synonyms page]Manage and Add synonym s…
Browse files Browse the repository at this point in the history
…et modal dialogs missing title from announcement (elastic#202326)

Closes: elastic#202268

## Description
Dialog modal visible title should be announced for the users, especially
using assistive technology to know what dialog modal, flyout opened.

## Changes made:

1. aria-labelledby={modalTitleId} attribute was added for mentioned
EuiModal

# Screen

<img width="962" alt="Screenshot 2024-11-29 at 16 24 15"
src="https://github.com/user-attachments/assets/50f41305-8f68-4f0b-866f-3f37da2cbcc9">
  • Loading branch information
alexwizp authored and CAWilson94 committed Dec 12, 2024
1 parent 97c3676 commit 61b5b31
Showing 1 changed file with 10 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import {
EuiFlexItem,
EuiButton,
EuiButtonEmpty,
useGeneratedHtmlId,
} from '@elastic/eui';
import { i18n } from '@kbn/i18n';

Expand All @@ -37,6 +38,7 @@ export const SynonymModal: React.FC = () => {
const { isModalOpen, modalLoading, activeSynonymSet } = useValues(SynonymsLogic);
const { closeModal, createSynonymSet, updateSynonymSet, deleteSynonymSet } =
useActions(SynonymsLogic);
const modalTitleId = useGeneratedHtmlId();

const modalTitle = activeSynonymSet ? SYNONYM_UPDATE_TITLE : SYNONYM_CREATE_TITLE;
const id = activeSynonymSet?.id || 'createNewSynonymSet';
Expand All @@ -46,9 +48,9 @@ export const SynonymModal: React.FC = () => {
: (newSynonyms: string[]) => createSynonymSet(newSynonyms);

return isModalOpen ? (
<EuiModal onClose={closeModal}>
<EuiModal onClose={closeModal} aria-labelledby={modalTitleId}>
<EuiModalHeader>
<EuiModalHeaderTitle>{modalTitle}</EuiModalHeaderTitle>
<EuiModalHeaderTitle id={modalTitleId}>{modalTitle}</EuiModalHeaderTitle>
</EuiModalHeader>
<FlashMessages />
<EuiModalBody>
Expand Down Expand Up @@ -82,7 +84,12 @@ export const SynonymModal: React.FC = () => {
)}
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiButtonEmpty onClick={closeModal}>{CANCEL_BUTTON_LABEL}</EuiButtonEmpty>
<EuiButtonEmpty
data-test-subj="enterpriseSearchSynonymModalButton"
onClick={closeModal}
>
{CANCEL_BUTTON_LABEL}
</EuiButtonEmpty>
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiButton
Expand Down

0 comments on commit 61b5b31

Please sign in to comment.