Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflows update | Badges | Torch | New pipeline API #6

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

spirosmaggioros
Copy link
Member

@spirosmaggioros spirosmaggioros commented Nov 7, 2024

Badges, building workflows and torch update

Documentation updates:

  • README.md: Added badges for macOS and Ubuntu build statuses, as well as a badge for the PyPI stable version.

Update Created a run_pipeline function in a seperate file called dlmuse_pipeline.py that will be used when calling DLMUSE with code instead of the CLI(i.e. will be directly used in NiChart_DLMUSE)

Warning: Due to the fact that i don't have a GPU anymore, i wasn't able to test my code, though building tests pass, we need to make sure that it outputs correct results. Please test it briefly with a small dataset before merging.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we confirmed that this nnunet version works on Python 3.13?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlexanderGetka-cbica, i renamed the PR and i added some stuff that we talked about yesterday at NiChart DLMUSE.

@spirosmaggioros spirosmaggioros marked this pull request as draft November 8, 2024 00:18
@spirosmaggioros spirosmaggioros marked this pull request as ready for review December 9, 2024 16:39
@spirosmaggioros spirosmaggioros changed the title Python 3.13 support for DLMUSE Workflows update | Badges Dec 9, 2024
@spirosmaggioros spirosmaggioros self-assigned this Dec 11, 2024
@spirosmaggioros
Copy link
Member Author

Update: Set torch version to 2.3.1. I didn't see anything wrong nor a compatibility issue. Though again i can't run this locally, i only tested the code till the running step.

@spirosmaggioros spirosmaggioros changed the title Workflows update | Badges Workflows update | Badges | Torch | New pipeline API Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants