Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Parallelization] Performed batch splitting and parallelization of the pipeline #39

Merged
merged 19 commits into from
Oct 11, 2024
Merged

[Parallelization] Performed batch splitting and parallelization of the pipeline #39

merged 19 commits into from
Oct 11, 2024

Conversation

spirosmaggioros
Copy link
Member

@spirosmaggioros spirosmaggioros commented Oct 9, 2024 •
edited
Loading

Parallelization

This will be a draft PR for testing purposes till we finalize it and see if it'll be merged. Currently there's no GPU support from my side and the team should look at it.

Results are here:

serial with GPU:
real    10m44.892s
user    27m24.860s
sys     4m7.473s

Parallel with GPU:
real    5m3.205s
user    32m49.719s
sys     6m24.975s

@spirosmaggioros spirosmaggioros marked this pull request as draft October 9, 2024 12:00
@spirosmaggioros spirosmaggioros self-assigned this Oct 9, 2024
@spirosmaggioros spirosmaggioros marked this pull request as ready for review October 9, 2024 20:52
AlexanderGetka-cbica
AlexanderGetka-cbica reviewed Oct 11, 2024
View reviewed changes
Copy link
Contributor

@AlexanderGetka-cbica AlexanderGetka-cbica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the output/results directories should be tracked on git here. Can you remove these? Otherwise, looks good and approved!

@AlexanderGetka-cbica AlexanderGetka-cbica merged commit 2e2db89 into CBICA:main Oct 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderGetka-cbica AlexanderGetka-cbica AlexanderGetka-cbica approved these changes

@gurayerus gurayerus Awaiting requested review from gurayerus

@euroso97 euroso97 Awaiting requested review from euroso97

Assignees

@spirosmaggioros spirosmaggioros

Labels
optimization parallelization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spirosmaggioros @AlexanderGetka-cbica