Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issues with parallelization #47

Merged
merged 7 commits into from
Oct 30, 2024
Merged

Fixing issues with parallelization #47

merged 7 commits into from
Oct 30, 2024

Conversation

spirosmaggioros
Copy link
Member

Issues with parallelization

  • Changed double division to integer division
  • Transformed --cores(-c) to int from str
  • Empty output folder if it has files in it from previous runs
  • Made pre-commit pass

With these changes, even if the number of total files you have is smaller than the cores, it runs perfectly. It looked fine before, but i believe it was due to the double division and the args.cores not being transformed to an int.
@AlexanderGetka-cbica This should resolve issue #41.

@spirosmaggioros spirosmaggioros added bug Something isn't working parallelization labels Oct 29, 2024
@spirosmaggioros spirosmaggioros self-assigned this Oct 29, 2024
@spirosmaggioros spirosmaggioros linked an issue Oct 29, 2024 that may be closed by this pull request
@spirosmaggioros spirosmaggioros merged commit 875de6b into main Oct 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working parallelization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filename error (Docker)
2 participants