Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test cases fixes and pre-commit update #34

Merged
merged 3 commits into from
Jan 14, 2025
Merged

Conversation

spirosmaggioros
Copy link
Member

@spirosmaggioros spirosmaggioros commented Dec 9, 2024

Some test cases weren't running on some versions(locally) just because we were passing types very dynamically. This issue appears only on test cases, so there are no issues whatsoever. But we have to make sure when a function returns a pd.Dataframe or a str for example. Everything works fine now.

Also, removed some files that we don't need.

Code Cleanup and Removal:

Type Hint Improvements:

Minor Adjustments:

  • spare_scores/util.py: Changed the check_file_exists function to accept an Optional[str] type for the filename parameter.
  • spare_scores/cli.py: Reorganized imports for better readability and consistency.
  • spare_scores/data_prep.py: Modified the age_sex_match function to check if to_match is not an empty string instead of None.

Test File Adjustments:

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.34%. Comparing base (ed3b3a1) to head (6195a55).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
+ Coverage   81.01%   81.34%   +0.33%     
==========================================
  Files          11       11              
  Lines        1385     1394       +9     
==========================================
+ Hits         1122     1134      +12     
+ Misses        263      260       -3     
Files with missing lines Coverage Δ
spare_scores/data_prep.py 66.13% <100.00%> (+1.58%) ⬆️
spare_scores/util.py 93.50% <100.00%> (ø)
tests/unit/test_data_prep.py 100.00% <100.00%> (ø)
tests/unit/test_spare_scores.py 100.00% <100.00%> (ø)
tests/unit/test_util.py 100.00% <100.00%> (ø)

@spirosmaggioros
Copy link
Member Author

@AlexanderGetka-cbica Can you please review this?

@AlexanderGetka-cbica AlexanderGetka-cbica merged commit 283046f into main Jan 14, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants