Test cases fixes and pre-commit update #34
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some test cases weren't running on some versions(locally) just because we were passing types very dynamically. This issue appears only on test cases, so there are no issues whatsoever. But we have to make sure when a function returns a pd.Dataframe or a str for example. Everything works fine now.
Also, removed some files that we don't need.
Code Cleanup and Removal:
merge_ROI_demo_and_test.py
: Removed the entire script as it was redundant and no longer needed.Type Hint Improvements:
tests/unit/test_data_prep.py
: Added type hints to several test functions to improve code clarity and type safety. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Minor Adjustments:
spare_scores/util.py
: Changed thecheck_file_exists
function to accept anOptional[str]
type for thefilename
parameter.spare_scores/cli.py
: Reorganized imports for better readability and consistency.spare_scores/data_prep.py
: Modified theage_sex_match
function to check ifto_match
is not an empty string instead ofNone
.Test File Adjustments:
tests/conftest.py
: Removed unused script.