Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add values for CMB data #29

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Add values for CMB data #29

merged 1 commit into from
Aug 30, 2024

Conversation

kuffelgr
Copy link
Collaborator

This PR adds valid permissible values for the properties snomed_disease_term and meddra_disease_code. These values are represented in the CMB data and are valid values per SNOMED and MEDDRA.

@kuffelgr kuffelgr requested a review from pihltd August 30, 2024 20:50
Copy link
Collaborator

@pihltd pihltd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a couple of small changes though these fields are poster children for why we want to point to the PVs of CDEs.

The two multiple myeloma entries look odd (same ID but one with an "a" slapped on the end, but that can be corrected later if it is not correct.

@kuffelgr kuffelgr merged commit 8f6c99e into develop Aug 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants