MVDM - begin finalization #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplified the diagnosis and specimen nodes by commenting out properties beyond those identified as our MVDM targets
Commented out a <Req: 'Yes'> that wasn't included in a block of commenting out
Added a list of acceptable terms for the data_file_format property to support the generation of mock data
Removed controlled vocabularies used to drive the generation of mock data Simplified several controlled vocabularies to match acceptable terms to CMB data values Removed definitions for several properties that are no longer relevant
Deleted a number of properties that had already been commented out
Added and/or updated CDE references throughout the data model, per the recommendations of the SI Team, except where the proposed CDEs were either clearly problematic at best, or simply incorrect at worst.
Fixed multiple instances of the same syntax error within the principal_investigator node
Fixed error at line 224 where the CDE "Value" of Image Collection Name been inserted in the wrong place
Corrected numerous errors revealed by careful inspection of the data model via the temporary instance of the Data Model Navigator Also added some textual pointers as to why references to certain problematic CDEs have not been added
Propagated IDs for updated and newly-assigned CDEs from the ctdc_model_properties_file.yaml file into the ctdc_model_file.yaml file in order to make it easier to assess our overall CDE coverage across nodes and properties. At the same time, proofed the existing CDE referencing information, and corrected a number of CDE IDs that had dropped either the first or last of their digits due to copy/paste errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplified the diagnosis and specimen nodes by commenting out properties beyond those identified as our MVDM targets