Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add opt_out column to expt_assignments table #22

Merged
merged 6 commits into from
Jul 29, 2024
Merged

Conversation

karlhigley
Copy link
Collaborator

This also renames the table from expt_allocations to expt_assignments. That felt more urgent now that we're going to have additional tables (like datasets and account_aliases) that will connect to related tables like accounts.

@karlhigley karlhigley requested a review from kluver July 26, 2024 14:16
@karlhigley karlhigley self-assigned this Jul 26, 2024
Copy link
Contributor

@kluver kluver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should figure out what we want to do with the code style failures, but the code itself seems straightforward and good.

@kluver
Copy link
Contributor

kluver commented Jul 26, 2024

I was hoping to downstream some changes from this PR (so I didn't have to deal with the alembic merge) -- I don't think this passes the database tests.

@kluver
Copy link
Contributor

kluver commented Jul 26, 2024

I was hoping to downstream some changes from this PR (so I didn't have to deal with the alembic merge) -- I don't think this passes the database tests.

    if isinstance(revision.down_revision, tuple):
        return  # don't test merge revisions

Adding this to the staircase test "fixes" it -- it does prevent testing merge revisions, but I think we can plan to always have empty merge revisions

@karlhigley karlhigley marked this pull request as ready for review July 29, 2024 13:18
@karlhigley karlhigley merged commit e1b9686 into main Jul 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants