Remove repository method name aliases #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We put these in for backward compatibility while we updated the other repos which will soon be complete, so we're ready to remove the aliases.
kluver
approved these changes
Aug 13, 2024
| @@ -93,11 +93,11 @@ def fetch_unassigned_accounts(self, start_date: date, end_date: date): | |||
| group_ids = self._id_query(group_query) | |||
|
|
|||
| # Find the users allocated to those groups | |||
| allocation_query = select(allocation_tbl.c.account_id).where(allocation_tbl.c.group_id.in_(group_ids)) | |||
| allocation_account_ids = self._id_query(allocation_query) | |||
| assignment_query = select(assignment_tbl.c.account_id).where(assignment_tbl.c.group_id.in_(group_ids)) | |||
There was a problem hiding this comment.
I'm pretty sure we made this change a while ago. Maybe we're just not using this function?
There was a problem hiding this comment.
Yeah, that's exactly it—we haven't tried to do anything with experiment assignments since the change happened
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We put these in for backward compatibility while we updated the other repos which will soon be complete, so we're ready to remove the aliases.
Depends on https://github.com/CCRI-POPROX/poprox-platform/pull/135 and CCRI-POPROX/poprox-web#3