Clean up database test fixtures #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to work seamlessly with a local database, we also need to use the same database engine that the connection was created from. Otherwise we run the risk of e.g. connecting to the prod database and running a bunch of delete statements.
kluver
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
lgtm,
If the concern is about connecting to the "wrong" database is there some way to take this further? Just brainstorming, but we could probably instrument the test database to put a table with a specific value in it and we can do a positive check for that on test start up and halt-out if we don't see that?
|
This was less of an abstract concern and more of a "wait, I can't actually run the tests because it's trying to talk to two different databases" 😅 (No objection to further iteration on this though) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to work seamlessly with a local database, we also need to use the same database engine that the connection was created from. Otherwise we run the risk of e.g. connecting to the prod database and running a bunch of delete statements.