Switch to using direct repository injection #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kluver
commented
Aug 20, 2024
|
|
||
|
|
||
| class DatabaseRepository: | ||
| _repository_types = {} | ||
| _repository_types = set() |
There was a problem hiding this comment.
Switched to set since we don't care what the parameter is named anymore -- this does formally require annotating parameters, but working with this type of magic that's probably for the best.
karlhigley
approved these changes
Aug 20, 2024
| @wraps(handler) | ||
| def wrapper(event, context): | ||
| with DB_ENGINE.connect() as conn: | ||
| # this will be a dictionary containing all parameters (with type annotations) |
There was a problem hiding this comment.
This could probably be a type annotation along the lines of dict[str, type]
kluver
merged commit d99fe8c
into
karl/refactor/repository-registration
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.