Add preview image id to impressions table #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Mahamudul42
commented
Jan 31, 2025
Mahamudul42
commented
- Newsletter class is modified for preview images.
- Migration file is added to insert a new column.
…lt into a dictionary
…lt into a dictionary and initialized with defaultdict
karlhigley
changed the title
|
It looks like one of the tests needs an update to include a preview image id when it creates an |
@Mahamudul42 -- let us know if you need help getting the tests to run locally by-the-way. I can't remember if we got that working on your dev environment or not, but I remember running into trouble with that on someone's computer lately. Without the tests passing I don't think it's a good idea to merge this. |
karlhigley
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.