Removing all wildcard imports

[ksbeattie]

Fixes/Addresses:

The next step in #1162: this PR removes all wildcard imports as reported by pylint and adds that check to GHA.

Summary/Motivation:

Clean up the code

Changes proposed in this PR:

• Tons

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

1. I agree my contributions are submitted under the copyright and license terms described in the LICENSE.md file at the top level of this directory.
2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

[codecov]

Codecov Report

Attention: Patch coverage is 92.30769% with 14 lines in your changes missing coverage. Please review.

Project coverage is 38.49%. Comparing base (62534b8) to head (0e1a49c).

Files with missing lines	Patch %	Lines
foqus_lib/gui/sdoe/sdoeSetupFrame.py	60.00%	8 Missing ⚠️
foqus_lib/framework/pymodel/heat_integration.py	0.00%	2 Missing ⚠️
foqus_lib/framework/pymodel/steam_cycle.py	0.00%	2 Missing ⚠️
foqus_lib/framework/optimizer/SM_Optimizer.py	66.66%	1 Missing ⚠️
...qus_lib/framework/solventfit/SolventFit_testing.py	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1252      +/-   ##
==========================================
+ Coverage   38.47%   38.49%   +0.01%     
==========================================
  Files         164      164              
  Lines       37020    37029       +9     
  Branches     5728     5728              
==========================================
+ Hits        14243    14253      +10     
+ Misses      21650    21649       -1     
  Partials     1127     1127              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bpaul4]

Thanks @ksbeattie for doing this, I see that there was a significant amount of nested wildcard importing going on. I have a few questions but overall this looks nice.

[bpaul4]

It doesn't look like this import is covered, or necessary. Can this be removed?

[ksbeattie]

Yes, this is a tricky one. I left it in and added the pylint disable because I believe that Anuja (who wrote this code) was using it to detect if the SM Opt "plugin" was available or not. I actually couldn't find where else it is used. I would like to get @anujad95 to review and test this part directly, if possible.

[bpaul4]

Digging a bit into the files, the coverage issue is because this file is never executed directly:

FOQUS/foqus_lib/gui/tests/test_plugins.py

Line 165 in 62534b8

# def test_load_and_run_heatintegration(self, active_session, simnode):

[ksbeattie]

I believe this is related to the whole plugin management problem (described in #1085) but shelved due to lack of time. If we could get it into the CI somehow, that would be great.

[bpaul4]

This is also not covered by the tests.

[ksbeattie]

I'm all for adding more test coverage, I was just concentrating on removing all the wildcard-imports for this PR.