Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix terraform deployment #378

Merged
merged 6 commits into from
Feb 18, 2025
Merged

Fix terraform deployment #378

merged 6 commits into from
Feb 18, 2025

Conversation

shanice-skylight
Copy link
Collaborator

@shanice-skylight shanice-skylight commented Feb 14, 2025

PULL REQUEST

Summary

Terraform is waiting for input to select the workspace. Since the workflow is triggered automatically by a merge on the main branch, no input is provided. This PR by default, on merge to main deploys to dev, while deployment to demo will continue to be done manually via the Github Action named Terraform Plan & Terraform Apply.

In the future, if needed, a separate PR can be created to automate deployment to demo once dev is complete. However, there are times, such as during Connectathon, when it’s preferable for dev and demo to be in different states.

Related Issue

Fixes #

Additional Information

Anything else the review team should know?

Checklist

  • Descriptive Pull Request title
  • Link to relevant issues
  • Provide necessary context for design reviewers
  • Update documentation

@shanice-skylight shanice-skylight self-assigned this Feb 14, 2025
Copy link

github-actions bot commented Feb 14, 2025

Coverage report for ./query-connector

St.
Category Percentage Covered / Total
🔴 Statements 53.64% 935/1743
🔴 Branches 53.66% 293/546
🔴 Functions 52.6% 192/365
🔴 Lines 53.7% 878/1635

Test suite run success

72 tests passing in 9 suites.

Report generated by 🧪jest coverage report action from b6c969a

shanice-skylight and others added 4 commits February 18, 2025 14:03
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Rob Mitchell <[email protected]>
Co-authored-by: Rob Mitchell <[email protected]>
Copy link
Member

@nickclyde nickclyde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Shanice!!

@nickclyde nickclyde merged commit 36f4dd4 into main Feb 18, 2025
12 checks passed
@nickclyde nickclyde deleted the shanice/hotfix-terraform branch February 18, 2025 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants