fix: abnormal flag display #2941
Conversation
mcmcgrath13
requested review from
angelathe,
BobanL,
lina-roth,
gordonfarrell,
JNygaard-Skylight,
austin-hall-skylight,
akasper and
robertmitchellv
| @@ -126,7 +126,7 @@ specimenSource: "Observation.extension[0].extension.where(url = 'specimen source | |||
| observationReferenceValue: "Observation.extension[0].extension.where(url = 'observation entry reference value').valueString" | |||
| observationComponent: "code.coding.display.first()" | |||
| # observationValue logic: <value> <units> (<interpretation>) | |||
| observationValue: (valueQuantity.value.toString() | valueString | valueCodeableConcept.coding.display | iif(valueQuantity.unit.exists(), iif(valueQuantity.unit = '%', valueQuantity.unit, ' ' | valueQuantity.unit), '') | iif(interpretation.coding.display.exists(), ' (' | interpretation.coding.display | ')', '')).join('') | |||
| observationValue: (valueQuantity.value.toString() | valueString | valueCodeableConcept.coding.display | iif(valueQuantity.unit.exists(), iif(valueQuantity.unit = '%', valueQuantity.unit, ' ' + valueQuantity.unit), '') | iif(interpretation.coding.display.exists(), ' (' + interpretation.coding.display + ')', '')).join('') | |||
There was a problem hiding this comment.
instead of using the display, I think the ticket and the screenshot specifically called out using the coding.code instead.
There was a problem hiding this comment.
It did use the word code, but I interpretted that more colloquially since the emphasis was on the missingness and other results had the long form and that wasn't called out in the ticket as an issue. @ashton-skylight which would you prefer? (I kind of prefer the short, but it does leave more room for interpretation)
There was a problem hiding this comment.
@mcmcgrath13 From what you've seen, are the two values generally abnormal and high?
There was a problem hiding this comment.
in all of our sample data that has interpretations, they use this codeset. Most common sightings: High, Normal, Low, Abnormal, Alert Abnormal, Critical Abnormal
There was a problem hiding this comment.
@mcmcgrath13 There are quite a few codesets. Wondering if user readability is easier with the display name?
There was a problem hiding this comment.
@ashton-skylight upon looking at the codes, I think it's probably better to be explicit/long here even though the common codes are kinda obvious. There are some in there that I would not know how to interpret without going to do the lookup
There was a problem hiding this comment.
@mcmcgrath13 Agreed, it might be somewhat redundant, but would hopefully save time for users to not have to interpret codes outside of the common sightings
PULL REQUEST
Summary
Fix the display of interpretation codes so that they always display.
With the prior logic, due to the set nature of fhirpath, if the value and the interpretation were the same, then only the value would display along with empty parens.
Related Issue
Fixes #2715
Additional Information