Optional feature: crash started task on timeout instead of deleting #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related issue: #250 |
psrok1
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Looks good, thanks! I've made a small change and moved "Effective config" banner from SystemService constructor to the _log_config method that is called in loop.
I have also reverted comment on self.log.info("[%s] Processing task %s", ...), I guess it was leftover from testing.
|
Ah, tests failed due to EOL of Python 3.7/3.8 - these version were removed from setup-python. Let me fix that. |
psrok1
force-pushed
the
feature/crash-started-tasks-on-timeout
branch
from
0a4fe5f to
04b47cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This PR introduces alternative behavior for STARTED tasks on their timeout.
For now karton deletes such tasks, but in certain scenarios it's preferable to crash them.
Also this PR shows effective config applied on karton dispatcher to ease testing with mixed parameter sources (command-line args, karton.ini, default values).