Fix Prometheus metrics MIME type and bump prometheus-client to 0.21.1 #1016
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
What is the current behaviour?
/api/varz
offers Prometheus metrics but sends them with genericapplication/octet-stream
Content Type.What is the new behaviour?
prometheus_client.CONTENT_TYPE_LATEST
)prometheus-client
to latest. I initially thought that 0.20.0 updates the PrometheusText version to 1.0.0, but misread the changelog and the bump was for OpenMetricsText, so the format we're using stays on0.0.4
. Anyway, it's always a good opportunity to bump the version.