ipfixprobe: MSS fix #199
Closed
ipfixprobe: MSS fix #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSS opt has 4bytes, but value has only 2bytes.
To be checked, maybe more modifications neccesary.
|
If I understand it well, parsing a 4-byte value is fine, you just need to interpret the result correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parser is parsing MSS value as 4 byte variable instead of 2 bytes.
MSS option has 4 bytes: 1B kind, 1B length and only 2B value.
In current condition MSS value generated by ipfixprobe is incorrect and MSS field size is too big.
Parser fix should be easy, ipfixprobe fields change needs revision.