-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Top 10 ports #238
Open
Zadamsa
wants to merge
2
commits into
CESNET:master
Choose a base branch
from
Zadamsa:top-10-ports
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Top 10 ports #238
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,83 @@ | ||
/** | ||
* \file topPorts.hpp | ||
* \brief Template class implementing the most popular ports. | ||
* \author Damir Zainullin <[email protected]> | ||
* \date 2024 | ||
*/ | ||
#pragma once | ||
|
||
#include <array> | ||
#include <cmath> | ||
#include <cstdint> | ||
#include <functional> | ||
#include <limits> | ||
#include <queue> | ||
#include <unordered_map> | ||
#include <unordered_set> | ||
|
||
namespace ipxp { | ||
/** | ||
* \brief Top ports counter. | ||
* \tparam TopPortsCount Number of the most popular ports to store. | ||
*/ | ||
template<std::size_t TopPortsCount> | ||
class TopPorts { | ||
public: | ||
/** | ||
* \brief Insert a port into the top ports. | ||
* \param port Port to insert. | ||
*/ | ||
void insert(uint16_t port) noexcept | ||
{ | ||
m_port_frequencies[port]++; | ||
|
||
if (m_ports_present.size() < TopPortsCount) { | ||
m_ports_present.insert(port); | ||
m_least_popuplar_top_port = find_least_popular_top_port(); | ||
return; | ||
} | ||
|
||
if (auto it = m_ports_present.find(port); it == m_ports_present.end() | ||
&& m_port_frequencies[port] > m_port_frequencies[m_least_popuplar_top_port]) { | ||
m_ports_present.erase(m_least_popuplar_top_port); | ||
m_least_popuplar_top_port = port; | ||
m_ports_present.insert(port); | ||
} else if (port == m_least_popuplar_top_port) { | ||
m_least_popuplar_top_port = find_least_popular_top_port(); | ||
} | ||
} | ||
|
||
/** | ||
* \brief Get the top ports. | ||
* \return Pair of the top ports array and their count. | ||
*/ | ||
std::pair<std::array<std::pair<uint16_t, size_t>, TopPortsCount>, size_t> | ||
get_top_ports() const noexcept | ||
{ | ||
std::array<std::pair<uint16_t, size_t>, TopPortsCount> res; | ||
std::transform( | ||
m_ports_present.begin(), | ||
m_ports_present.end(), | ||
res.begin(), | ||
[this](uint16_t port) { return std::make_pair(port, m_port_frequencies[port]); }); | ||
std::sort(res.begin(), res.begin() + m_ports_present.size(), [] (const std::pair<uint16_t, size_t>& port1, const std::pair<uint16_t, size_t>& port2){ return port1.second > port2.second;}); | ||
return {res, m_ports_present.size()}; | ||
} | ||
|
||
private: | ||
uint16_t find_least_popular_top_port() const noexcept | ||
{ | ||
return *std::min_element( | ||
m_ports_present.begin(), | ||
m_ports_present.end(), | ||
[this](uint16_t port1, uint16_t port2) { | ||
return m_port_frequencies[port1] < m_port_frequencies[port2]; | ||
}); | ||
} | ||
|
||
std::array<std::size_t, 65536> m_port_frequencies {}; | ||
uint16_t m_least_popuplar_top_port {0}; | ||
std::unordered_set<uint16_t> m_ports_present; | ||
}; | ||
|
||
} // namespace ipxp |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
V procesních vláknech, které provádí zpracování paketů by neměla být žádná složitější logika zbytečně navíc.
Tato aktualizace top portů má v sobě docela složitou logiku, která by tu být neměla.
Jediné, co by procesní vlákna zde měla dělat je zvýšení čítače pro daný port.
Veškerá složitější logika, která zobrazí top 10 portů atd. by se měla řešit při vyčítání telemetrii.