Support building a static library #446
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is literally the bare minimum that one has to do in order to let a properly configured CMake do its thing and produce a static library.
michalvasko
approved these changes
Nov 15, 2023
|
Alright, seems like the right way to support this and we should update other projects this way, too. But please fix the conflicts before merging. |
|
this will need some time on my end because we're currently stuck with the pre-v3/v4/whatever recent push (and we're testing some server-specific mock with actual communication samples, so that might take time) |
michalvasko
added a commit
that referenced
this pull request
Apr 25, 2024
michalvasko
added a commit
that referenced
this pull request
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is literally the bare minimum that one has to do in order to let a properly configured CMake do its thing and produce a static library.
v2: be lazy and rely on CMake's builtin features
I'm deliberately not using CMake's standard way through theBUILD_SHARED_LIBSoption because the other libraries in the NETCONF/YANG stack already stick to this custom convention.