Feature/identity #118
Closed
Feature/identity #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch introduces new class ExtensionPlugin, which is wrapper around libyang extension plugin, which allows user to define custom action for parsing, compiling, and freeing parsed or compiled extensions. Custom actions can also raise a new type of exception LibyangExtensionError, which allows proper translation of exception to libyang error codes and logging of error message Signed-off-by: Stefan Gula <[email protected]>
This patch introduces PNode alternative to SNode, which allows to travers parsed module tree including groupings, uses and other special nodes Signed-off-by: Stefan Gula <[email protected]>
This patch introduces Identity and PIdentity classes. It also adds identities() API to get list of identities from Module Signed-off-by: Stefan Gula <[email protected]>
steweg
force-pushed
the
feature/identity
branch
from
9927dfa to
ac058c7
Compare
|
Could you rebase this on the master branch please, it will make things easier? Also, why is the ExtensionPlugin part needed for the Identities? |
|
Will do that. Regarding the dependency, I have made this code after the Extension plugin patch and wanted to keep the same way of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds Identity and PIdentity classes. But it requires PRs #116 and #102.
I also believe that it conflicts with #117 as that patch introduces just the parts and not the compiled ones.