Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/multiple fixes #74

Closed
wants to merge 4 commits into from
Closed

Conversation

steweg
Copy link
Contributor

@steweg steweg commented Dec 7, 2023

This patch fixes multiple issues:

  • defaults function output
  • union_types function
  • find_path function
  • fixes broken tox/lint with python3.12

@steweg steweg force-pushed the feature/multiple_fixes branch from b044681 to cf7c0fd Compare December 7, 2023 09:21
This patch fixes union_types output in case of using
typedefs which uses union within with another typedefs/unions
@steweg steweg force-pushed the feature/multiple_fixes branch from cf7c0fd to 55d3e4c Compare December 7, 2023 09:30
@steweg steweg force-pushed the feature/multiple_fixes branch 6 times, most recently from 14dcfa7 to 99d3cea Compare December 7, 2023 12:20
@steweg steweg force-pushed the feature/multiple_fixes branch from 99d3cea to f1cc29c Compare December 7, 2023 13:09
@samuel-gauthier
Copy link
Collaborator

Hi steweg,

I will gladly have a look.

However, could you first conform to the project pull request guidelines?

  • can you add unit tests to your commits?
  • can you add proper commit logs, and check your commit titles, as described in the project guidelines?
  • ideally, could you submit your pull requests by feature, instead of "multiple_fixes", it will make it easier to split amongst the maintainers

Thanks,
Samuel

@steweg
Copy link
Contributor Author

steweg commented Jan 25, 2024

Closing this PR as it was split based on request to #80, #81, #82, #83

@steweg steweg closed this Jan 25, 2024
@steweg steweg deleted the feature/multiple_fixes branch January 25, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants