Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/multiple enhancements #75

Closed
wants to merge 12 commits into from

Conversation

steweg
Copy link
Contributor

@steweg steweg commented Dec 7, 2023

This PR includes multiple enhancements:

  • Adding unlink function
  • Adding LY_CTX_LEAFREF_EXTENDED context option
  • Adding fraction_digits function for DLeaf
  • Adding min/max_elements and uniques
  • Reworked musts to use common function
  • Enhancing Choice/Case options
  • Extending pattern options
  • Adding require_instance function
  • Adding Type.derived_cdata function
  • Adding insert_sibling function
  • Adding only_node option to add_defaults

@samuel-gauthier
Copy link
Collaborator

Hi steweg,

Again, I will have a look, but...

same comment as for your other pull request, could you first conform to the project pull request guidelines?

  • can you add unit tests to your commits?
  • can you add proper commit logs, and check your commit titles, as described in the project guidelines?
  • ideally, could you submit your pull requests by feature, instead of "multiple_enhancements", it will make it easier to split amongst the maintainers

Thanks,
Samuel

@steweg
Copy link
Contributor Author

steweg commented Jan 25, 2024

So far split to PR #84, #85, #86, #87. To be continued tomorrow

@steweg
Copy link
Contributor Author

steweg commented Jan 26, 2024

Split was completed, PR from #88, #89, #90, #91, #92, #93, #94, #95 and #96. Closing this PR

@steweg steweg closed this Jan 26, 2024
@steweg steweg deleted the feature/multiple_enhancements branch December 16, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants