schema: enable getting node data path without list key #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no way to get a node data path (path without choice/case) without list keys. Adds the path_type parameter to the SNode.schema_path() method. This parameter can takes 3 values: - SNode.PATH_LOG: returns the path with schema-only nodes (choice, case) included, the default - SNode.PATH_DATA: returns the path without schema-only nodes - SNode.PATH_DATA_PATTERN: similar to PATH_DATA with list keys added (the one used by data_path()) The SNode.PATH_LOG is set by default to not change the original behavior. The SNode.data_path() method now calls SNode.schema_path() with self.PATH_DATA_PATTERN instead of lib.lysc_path(). Here is an example of the output difference between schema_path(), data_path(), and schema_path(path_type=SNode.PATH_DATA) with a node included in a choice and a list: node.schema_path(): /ietf-keystore:keystore/asymmetric-keys/asymmetric-key/private-key-type/private-key/private-key node.data_path() or node.schema_path(SNode.PATH_DATA_PATTERN): /ietf-keystore:keystore/asymmetric-keys/asymmetric-key[name='%s']/private-key node.schema_path(SNode.PATH_DATA): /ietf-keystore:keystore/asymmetric-keys/asymmetric-key/private-key Tests have been updated accordingly. Signed-off-by: Matthieu Ternisien d'Ouville <[email protected]>
MatthieuTdO-6WIND
force-pushed
the
master
branch
from
b447a79 to
221f921
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no way to get a node data path (path without choice/case) without list keys.
Adds the path_type parameter to the SNode.schema_path() method. This parameter can takes 3 values:
The SNode.PATH_LOG is set by default to not change the original behavior.
The SNode.data_path() method now calls SNode.schema_path() with self.PATH_DATA_PATTERN instead of lib.lysc_path().
Here is an example of the output difference between schema_path(), data_path(), and schema_path(path_type=SNode.PATH_DATA) with a node included in a choice and a list:
node.schema_path():
/ietf-keystore:keystore/asymmetric-keys/asymmetric-key/private-key-type/private-key/private-key node.data_path() or node.schema_path(SNode.PATH_DATA_PATTERN): /ietf-keystore:keystore/asymmetric-keys/asymmetric-key[name='%s']/private-key node.schema_path(SNode.PATH_DATA):
/ietf-keystore:keystore/asymmetric-keys/asymmetric-key/private-key