Avoid using uninitialized array offsets

CESNET · Sep 5, 2019 · 3cda491 · 3cda491
1 parent 03fe9b4
commit 3cda491
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/src/managers/VulnerabilitiesManager.php b/src/managers/VulnerabilitiesManager.php
@@ -138,8 +138,8 @@ private function dpkgvercmp_in($a, $b)
             $first_diff = 0;
 
             while (($i < $l && !ctype_digit($a[$i])) || ($j < $k && !ctype_digit($b[$j]))) {
-                $vc = $this->order($a[$i]);
-                $rc = $this->order($b[$j]);
+                $vc = ($i < $l) ? $this->order($a[$i]) : 0;
+                $rc = ($j < $k) ? $this->order($b[$j]) : 0;
                 if ($vc != $rc) {
                     return $vc - $rc;
                 }
@@ -186,9 +186,6 @@ private function dpkgvercmp_in($a, $b)
      */
     private function order($val)
     {
-        if ($val == '') {
-            return 0;
-        }
         if ($val == '~') {
             return -1;
         }