Script for fill in Pakiti DB of users from gocDB #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kouril
reviewed
Apr 2, 2019
src/common/site_admins.php
Outdated
|
|
||
| if ($seo === false) { | ||
| file_put_contents('php://stderr', "Cannot load list of Site Security Contats from the GOCDB"); | ||
| $seo_sites = array(); |
There was a problem hiding this comment.
If the file can't be loaded, just issue an error and bail out
kouril
reviewed
Apr 2, 2019
src/common/site_admins.php
Outdated
|
|
||
| if ($ngi_contacts === false) { | ||
| file_put_contents('php://stderr', "Cannot load list of NGI Security Officers from the GOCDB"); | ||
| $ngis = array(); |
There was a problem hiding this comment.
the same as above, i.e. die on errors
kouril
reviewed
Apr 2, 2019
src/common/site_admins.php
Outdated
| print($verbose); | ||
| # Get site security contacts | ||
| $seo = new DOMDocument(); | ||
| $seo->load("/tmp/pakiti-seo.xml", LIBXML_NOWARNING | LIBXML_NOERROR); |
There was a problem hiding this comment.
pass the names of input XML files as command-line parameters
kouril
reviewed
Apr 2, 2019
src/common/site_admins.php
Outdated
| $err = ''; | ||
| # Get NGI security officers | ||
| $ngi_contacts = new DOMDocument(); | ||
| $ngi_contacts->load("/tmp/pakiti-ngi-so.xml", LIBXML_NOWARNING | LIBXML_NOERROR); |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.