-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stripe billing and invoicing #180
base: master
Are you sure you want to change the base?
Conversation
…ut.session.completed` dummy job implementation
…, updated SubscriptionService, updated StripeCheckoutSessionCompletedJob
…ge, subscription page, Subscription History upgrade, SubscriptionService upgrade, StripeCheckoutSessionCompletedJob update
…riptionDeletedJob, BaseStripeJob upgrade, updated previous Jobs, updated docs
…b, table update, StripeCustomerSubscriptionUpdatedJob
….com/CGSmith-LLC/shipwise-api into feature/stripe-billing-and-invoicing # Conflicts: # composer.lock
* @param integer $id | ||
* @return Subscription the loaded model | ||
* @throws NotFoundHttpException if the model cannot be found | ||
* TODO: implement the logic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
???
Co-authored-by: Alexander Makarov <[email protected]>
Co-authored-by: Alexander Makarov <[email protected]>
Co-authored-by: Alexander Makarov <[email protected]>
Co-authored-by: Alexander Makarov <[email protected]>
Co-authored-by: Alexander Makarov <[email protected]>
Co-authored-by: Alexander Makarov <[email protected]>
…atedJob.php Co-authored-by: Alexander Makarov <[email protected]>
Co-authored-by: Alexander Makarov <[email protected]>
…dJob.php Co-authored-by: Alexander Makarov <[email protected]>
…dJob.php Co-authored-by: Alexander Makarov <[email protected]>
Co-authored-by: Alexander Makarov <[email protected]>
….com/CGSmith-LLC/shipwise-api into feature/stripe-billing-and-invoicing
common/config/main.php
Outdated
@@ -35,8 +35,8 @@ | |||
], | |||
'stripe' => [ | |||
'class' => 'common\components\StripeComponent', | |||
'publishableKey' => $params['stripe']['publishable_key'], | |||
'secretKey' => $params['stripe']['secret_key'], | |||
'publicKey' => $params['stripe']['publishable_key'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oww... sorry. My bad. These are actually named "secret key" and "publishable key" in Stripe API so it worth naming these the same way in the component.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem. I've reverted back my latest changes - e696a17
Starting review and testing this week. |
It's a DRAFT PR since there are some open questions about customers here - #174 (comment).
Docs ->
intro-docs/subscriptions.md
.Params: