-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flask reimplementation #19
Draft
rkrishnasanka
wants to merge
37
commits into
master
Choose a base branch
from
flask-reimplementation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed an incorrect dependency
- Updated the README.md to have a half decent development guide - Updated local docker dev environment to skip creating poetry virtualenv - Added some checks to see if the s3 bucket exists on the s3/minio - Completely overhauled tuthentication controller to be a lot more cleaner. - Added a Test connection method for the file system API - Added the firstname and lastname to the user model - Modified the login api to not generate messages from auth controller but rather generate everything from the Resource method itself - Updated the signup api to call from the auth controller - Updated the message passing to be standard along with the error codes - Demoed that `verify_jwt_in_request()` works correctly rather than the annotation - Updated the material design icons font assets. The material icon inclusion fixes the vue compilation problem but still does not include the resources into the bundle correct references for the displaying the icons in the webpage
…ts from the resource since these manipulations need to be done through the tasks controller.
- Added rest api endpoint for uploading files - Updated the filesystem method signatures to handle the user requested downloads and uploads
Updated the file api to include the logic to pull the payload from the request and dispatch the commands
…age route for socketio connectivity.
- Fixed the address of socketio during practice. Next up, need to fix this.
- Updated s3filesystemcontroller naming - Added boilerplate code for API generation - Extracted helper methods for naming in s3 file controller - Fixed method and updated signature for overwriting file - Add method for creating new files and updating file content - Added a convinience method for updating the workspace with a new file - Updated file resource with the corresponding kwargs to check correct rest data ingestion - Refactored to use helper+convinence methods TODO: Need to add all the marshaling + kwargs code
…nd deleting the files after
…pen api codegen. We still need to debug and see if the process code is working correctly. Otherwise, the AWS filesystem becomes a shared library between both packages
…neptune into flask-reimplementation
* Stripped the dev container docker to not have ratchety installation of pyenv, poetry and nodejs. * Renamed devcontainer config to make it separate * Started creating a new architecture for setting all the REST API for the fontend (will move to autogenerated typescript library shortly) * Added the Swagger Generated server into the flask reimplementation. The aim is to have a clean-ish swagger server implementation that we can dropin and replace when needed * Updated the api to have the update password endpoint and update user info * Updated the authentication controller with the latest set of endpoints. * Renamed the project's folder name * Updated the codebase and moved some of the references * Added the launch configs for vscode * Took out the old shell scripts * Renamed the package * Moved the job runner code * Moved out the dockerfile for the job runner and moved all the test scripts * Updated and verified the docker-compose config for worker to have the newer configs. Summary We now have a working open API based system. Caveat is that the current version of swagger UI doesn't support the Request Body parameters. But we can still use Postman to test it out.
…neptune into flask-reimplementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.