Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support right to left override character #13

Merged
merged 2 commits into from
Mar 18, 2017
Merged

Conversation

dputtick
Copy link
Contributor

The unicode right to left override character can be used for various attacks.
This commit:
* Detects this character in the filename on the source key
* Strips it from the path before copying it to the dest key
* Marks the file as dangerous (this character doesn't belong in a filename)
@codecov-io
Copy link

codecov-io commented Mar 17, 2017

Codecov Report

Merging #13 into master will increase coverage by 0.22%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
+ Coverage   84.41%   84.64%   +0.22%     
==========================================
  Files           3        3              
  Lines         539      547       +8     
==========================================
+ Hits          455      463       +8     
  Misses         84       84
Impacted Files Coverage Δ
bin/filecheck.py 78.11% <100%> (+0.54%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79b15fd...2a5decf. Read the comment docs.

@Rafiot Rafiot merged commit bfc6694 into CIRCL:master Mar 18, 2017
@dputtick dputtick deleted the rtl-char branch March 20, 2017 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants