disable save changes button until a "save-able" change has been made;… #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, so perhaps we should think about how the wording of "Save Option Changes" is clear to the user, and how obvious it is to the user that this button only activates after creating then editing changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… [close #119, 120]
One thing to note about this change...apparently the "Save Changes" button doesn't save everything. Adding a new option / image is automatically saved back to the server, without needing to click the button. So really the button only saves (I believe) the correct choice order, and for MW sentence, the text (for Image Sequence it currently saves the
labelas well, except that PR #142 removes that field). The button should be disabled until one of those fields changes, and then it activates.