Refactored Code to not nest functions over 4 levels deep #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…init into helper functions calling on each other to make it more readable
Pull Request Test Coverage Report for Build 12938988216Details
💛 - Coveralls |
|
resolves #149 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In file /src/topics/sorted.js, changed from lines 269 to 275 to not nest functions and instead changed the functions that were defined within topicData.filter() into constants to be called upon. Added console.log('Jonas Soh'); right before the changed lines to test the edited code runs smoothly when clicking on the fire "popular" icon. The coverage report shows the new code and raised no new errors.