forked from CMU-313/cmu-313-f24-nodebb-f24-NodeBB
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to add authorization to endorsement API #36
Open
vickyc2266
wants to merge
11
commits into
f24
Choose a base branch
from
vicky/add-auth-to-endorse-api
base: f24
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… but not printing - suspect cause of error here
…efined at line 8)
vickyc2266
added
bug
Something isn't working
incomplete
issues that were not successfully completed
labels
Oct 11, 2024
vickyc2266
changed the title
Vicky's merge attempt to debug endorse feature #26
Attempt to add authorization to endorsement API #26
Oct 11, 2024
vickyc2266
changed the title
Attempt to add authorization to endorsement API #26
Attempt to add authorization to endorsement API
Oct 11, 2024
Due to implementation not working 100% and incoming merge conflicts, we will not be accepting this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempted to resolve #26
Attempted to debug the ability for authentication with the endorsement feature of posts. Found that a potential reason for the test failure for the endorse posts feature could be because of undefined uid throughout different files that have to do with the endorsement feature in files such as src/socket.io/posts/tools.js, src/api/posts.js, test/helpers/index.js, test/socket.io.js, and etc
The following files were gone through and edited:
src/api/posts.js
src/posts/endorsement.js
src/privileges/posts.js
src/socket.io/posts/tools.js
test/helpers/index.js
test/posts.js
test/socket.io.js