Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update definition of the _alias.dictionary_uri attribute. #485

Merged
merged 4 commits into from
Apr 12, 2024
Merged

Update definition of the _alias.dictionary_uri attribute. #485

merged 4 commits into from
Apr 12, 2024

Conversation

vaitkus
Copy link
Collaborator

@vaitkus vaitkus commented Feb 23, 2024

Closes #481.

@vaitkus vaitkus mentioned this pull request Feb 23, 2024
Closed
@vaitkus vaitkus marked this pull request as draft April 4, 2024 09:53
@vaitkus vaitkus marked this pull request as ready for review April 4, 2024 12:25
@vaitkus
Copy link
Collaborator Author

vaitkus commented Apr 4, 2024

I have further updated the PR by adding the _alias.dictionary_version as discussed in #481. Note, that the pdbx/mmcif dictionary also has a similar attribute named _item_aliases.version.

See also PR #483 for an illustration of how the _alias.dictionary_uri and _alias.dictionary_version could be used in practice.

@vaitkus vaitkus requested a review from jamesrhester April 4, 2024 13:07
jamesrhester
jamesrhester reviewed Apr 11, 2024
View reviewed changes
ddl.dic Outdated Show resolved Hide resolved
@vaitkus vaitkus requested a review from jamesrhester April 11, 2024 14:27
@jamesrhester jamesrhester merged commit 9b3960b into COMCIFS:master Apr 12, 2024
3 checks passed
@vaitkus vaitkus deleted the clarify-semantics-of-alias-dictionary-uri branch April 12, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesrhester jamesrhester jamesrhester approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarify the semantics of the _alias.dictionary_uri attribute
2 participants
@vaitkus @jamesrhester