Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds npm install steps to publish workflow #23

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

TysonMN
Copy link
Contributor

@TysonMN TysonMN commented Sep 15, 2020

Resolves #20
...for reals this time ;)

The publish workflow needs install steps. After I added these install steps, the workflow passed for me. Still not sure if it will successfully publish a new version when it is supposed to. As I described in #22 (comment), I have successfully tested this workflow.

@TysonMN

This comment has been minimized.

@loreanvictor
Copy link
Contributor

P.s. the reason this is not merged is that I'm giving the concept a bit more test on some other (more experimental) packages to see how it fairs. So far, I can say:

  • I opted for using this action instead, since it seems to work better when you DO NOT want to have an additional check for some release message in the commit message. That workflow seems more streamlined to me since there is no magic anywhere in it and every bump in package.json simply means a new version is going to be published.

  • The workflow works pretty well when the package has tests (since it can simply stop if the tests are not passing, better yet you could even fail the publish if coverage is for example below a certain threshold). This package unfortunately does not (yet) have any tests, which makes it a bit more risky to do accidental automated publishes. That said, I still find myself making a separate commit for each publish when I am sure everything is ready, so perhaps thats not an issue.

I will use the same workflow on some bigger packages soon to see how things go, but it seems like a pretty convenient thing (since generally each new version DOES need at least one commit and then some other manual work).

@TysonMN
Copy link
Contributor Author

TysonMN commented Oct 26, 2020

Sounds good to me. I don't have any particular affinity for the Publish to npm action. I think it is just the first one that I found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate publishing of coding-blog-plugin
2 participants