Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/username #650

Merged
merged 25 commits into from
Oct 18, 2024
Merged

Fix/username #650

merged 25 commits into from
Oct 18, 2024

Conversation

pieryvdl
Copy link
Contributor

3 things that changed in this update:

  1. the readme is the biggest change
  2. I fixed the username bug that prevented a new user from changing their username (to test, make a new account via google)
  3. Updated the code in main.dart to cycle randomly between API keys to better manage our resources.

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 4.86%. Comparing base (b1d230c) to head (a2f7564).
Report is 28 commits behind head on Develop.

Files with missing lines Patch % Lines
lib/services/profile_S/profile_service.dart 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           Develop    #650      +/-   ##
==========================================
- Coverage     4.86%   4.86%   -0.01%     
==========================================
  Files          130     130              
  Lines         8339    8341       +2     
==========================================
  Hits           406     406              
- Misses        7933    7935       +2     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MonikaTheiss
Copy link
Contributor

Code looks good ! I will just test everything tomorrow to see how it all works 😄
One thing on the readme, would it perhaps be possible to somewhere just add our group email please? Everything else looks great,thank you!

@pieryvdl
Copy link
Contributor Author

Cool. Will add it! Thanks Monika!

@pieryvdl
Copy link
Contributor Author

@MonikaTheiss Added the content to the table at the bottom. 😄

@MonikaTheiss
Copy link
Contributor

perfect, thank you !
I just ran it all on my side. It works , thank you! Just waiting for actions to pass 👍

Copy link
Contributor

@MonikaTheiss MonikaTheiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this !

@pieryvdl pieryvdl merged commit a09ad53 into Develop Oct 18, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants