Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add : add time-zone-filter #21

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

add : add time-zone-filter #21

wants to merge 6 commits into from

Conversation

yunimm
Copy link

@yunimm yunimm commented Apr 23, 2023

@netlify
Copy link

netlify bot commented Apr 23, 2023

Deploy Preview for endearing-longma-1f4440 failed.

Name Link
🔨 Latest commit c2aaa16
🔍 Latest deploy log https://app.netlify.com/sites/endearing-longma-1f4440/deploys/64a0496288696000080407df

@yunimm yunimm requested review from DevilTea and yoyo930021 and removed request for DevilTea April 23, 2023 08:04
}

const updateInputTimeZone = (event) => {
inputTimeZone.value = event.target.value
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

少處理 Timezone 輸入錯誤的情境

v-show="isChangeTimeZone"
placeholder=""
:value="inputTimeZone"
@input="updateInputTimeZone"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以使用 v-model 精簡?

const { openPopUp, removeAll } = usePopUp()
const { xsOnly } = useBreakpoints()
const { locale } = useI18n()

const currentTimeZone = ref('')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我認為你可以把這個塞入 useSession
類似 React context 的用法

src/components/Session/ScheduleItem.vue Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants