-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change gallery building to use nbsphinx #206
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
43e62db
to
3b3e5fb
Compare
Solved by putting them in |
4e230a2
to
8da0721
Compare
To get the original behaviour for defaulting thumbnails to the last image in a notebook, we'd need spatialaudio/nbsphinx#707 (or something similar) to land. At the moment I've pointed RTD to my branch which includes this change. The way thumbnails are specified other than this default has also changed: either the image can go in |
Hey @angus-g, sorry I only just got around to checking this out. Looks good from my perspective. |
28ed96e
to
5384818
Compare
I see some conflicts here have risen in the |
Yeah, that's fine, I can resolve that. I still need to put some docs together for managing thumbnails, and it would be nice for the upstream PR to work first. Other than that, it's probably getting to a quiet enough time to switch over to nbsphinx and get prettier rendered notebooks! |
Do that! |
and open a new PR to keep working :) |
nbsphinx changes the toctree, so level 1 headers are going in as new TOC entries. We need to de-indent some of these to make the structure a bit more normal. We also fix an incorrect link in the MHT notebook.
We need to move them to the _static directory
5384818
to
73b836e
Compare
@navidcy mind having a poke around the build https://cosima-recipes--206.org.readthedocs.build/en/206/ and seeing if there's anything obviously broken? Otherwise I think this is ready to merge! |
The explorer tutorial looks great! Merge! |
Fixes #201 (see https://cosima-recipes.readthedocs.io/en/update-nbsphinx/tutorials/Using_Explorer_tools.html). However, we'll need to change how thumbnails are specified for galleries by tagging the cells with
nbsphinx-thumbnail
(https://nbsphinx.readthedocs.io/en/0.8.12/gallery/cell-tag.html). That's potentially pretty disruptive (will cause conflicts to everybody working on an existing notebook), so maybe we should wait for a quieter time to do that?See the WIP builds for this branch at: https://cosima-recipes.readthedocs.io/en/update-nbsphinx/
Notebook warnings
Warnings
From
DocumentedExamples/Meridional_heat_transport.ipynb
:From
DocumentedExamples/Surface_Water_Mass_Transformation.ipynb
: