Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paranoid GUI #378

Merged
merged 22 commits into from
Apr 22, 2016
Merged

Paranoid GUI #378

merged 22 commits into from
Apr 22, 2016

Conversation

CanOpener
Copy link
Contributor

Init, Mount, Unmount and Delete functionality implemented in GUI

@GoldenBadger
Copy link
Contributor

How much third-party code is on your branch's history? Not just in the latest commit.

{
"name" : "paranoid-gui",
"description" : "Paranoid GUI",
"version" : "0.0.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick, but this should be 0.1.0 for the first prerelease version.

@VoyTechnology
Copy link
Member

What's the status of this PR?

@VoyTechnology
Copy link
Member

Consider using CSS variables for things that share the same colour

@GoldenBadger GoldenBadger modified the milestones: Sprint 7, Sprint 6 Apr 21, 2016
@GoldenBadger
Copy link
Contributor

If your vertical resolution is too low (mine is 768) the background colours break.

Broken Background

@GoldenBadger
Copy link
Contributor

All error messages appear to be alerts, which gets quite annoying after a while.

@GoldenBadger
Copy link
Contributor

GoldenBadger commented Apr 21, 2016

This branch should be rebased off master in order to fix those failing builds.

EDIT: (done)

@CanOpener
Copy link
Contributor Author

CanOpener commented Apr 21, 2016

@GoldenBadger
"How much third-party code is on your branch's history? Not just in the latest commit."
css/bootstrap.min.css
css/site.css
scripts/jquery-2.2.2.min.js
^are all third party code files.

@SeanHealy33
Copy link
Contributor

what is the story with the pictures in the commit :)

<body>
<div id="header">
<div class="logo">
<a onclick="rowClicked(-1)">Paranoid<span>Filesystems</span></a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does -1 mean in this instance?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1 is the index of the home section

@SeanHealy33
Copy link
Contributor

Visually the code looks file. I'm a bit rusty on my js so I'm not really sure about how its implemented.
LGTM

@ConorGriffin37 ConorGriffin37 merged commit 06bc4f1 into master Apr 22, 2016
@ConorGriffin37 ConorGriffin37 deleted the feature/mladen/paranoid-gui branch April 22, 2016 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants