Skip to content

Commit

Permalink
Make clear that previous JSON export/import was for metadata.
Browse files Browse the repository at this point in the history
  • Loading branch information
zrho committed Jan 6, 2025
1 parent 7fd9c47 commit 2294908
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions hugr-core/src/export.rs
Original file line number Diff line number Diff line change
Expand Up @@ -563,7 +563,7 @@ impl<'a> Context<'a> {

for (name, value) in opdef.iter_misc() {
let name = self.bump.alloc_str(name);
let value = self.export_json(value);
let value = self.export_json_meta(value);
meta.push(model::MetaItem { name, value });
}

Expand Down Expand Up @@ -1054,14 +1054,14 @@ impl<'a> Context<'a> {

for (name, value) in metadata_map {
let name = self.bump.alloc_str(name);
let value = self.export_json(value);
let value = self.export_json_meta(value);
meta.push(model::MetaItem { name, value });
}

meta.into_bump_slice()
}

pub fn export_json(&mut self, value: &serde_json::Value) -> model::TermId {
pub fn export_json_meta(&mut self, value: &serde_json::Value) -> model::TermId {
let value = serde_json::to_string(value).expect("json values are always serializable");
let value = self.make_term(model::Term::Str(self.bump.alloc_str(&value)));
let value = self.bump.alloc_slice_copy(&[value]);
Expand Down
4 changes: 2 additions & 2 deletions hugr-core/src/import.rs
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ impl<'a> Context<'a> {
for meta_item in node_data.meta {
// TODO: For now we expect all metadata to be JSON since this is how
// it is handled in `hugr-core`.
let value = self.import_json_value(meta_item.value)?;
let value = self.import_json_meta(meta_item.value)?;
self.hugr.set_metadata(node, meta_item.name, value);
}

Expand Down Expand Up @@ -1262,7 +1262,7 @@ impl<'a> Context<'a> {
}
}

fn import_json_value(
fn import_json_meta(
&mut self,
term_id: model::TermId,
) -> Result<serde_json::Value, ImportError> {
Expand Down

0 comments on commit 2294908

Please sign in to comment.