feat: git subtree move in hugr-llvm #1601

doug-q · 2024-10-21T13:43:32Z

Due to the LLVM dependency the package is excluded from default CI runs, except check which does not require llvm.

A separate job for building and testing is added that runs on push to main.

Succesful CI run: https://github.com/CQCL/hugr/actions/runs/11860727905

… Add license.

Co-authored-by: doug-q <[email protected]>

feat: Emission for Call nodes

fix: Syntax error

chore: Add issue-to-project.yml, enable coverage

They were pointing to an invalid source directory.

ci: Fix change-filters

fix: sum type tag elision logic reversed

test: add a test for sum type tags

feat: Support `FunctionType` values

Note that this extension is not intended to be complete, just enough to get started. We include some simplification of test infrastructure, although it is not strictly necessary. An earlier approach required these changes.

We take this opportunity to move some auxilliary code out of emit.rs, and to fix up some docs in fat.rs. BREAKING CHANGE: `Namer::new` takes an additional parameter. --------- Co-authored-by: Alec Edgington <[email protected]>

…33)

Co-authored-by: Mark Koch <[email protected]>

We take the opportunity to tidy up cfg.rs a bit. `impl Copy for FatNode` will now work, and many other methods now have more appropriate lifetime constraints. The borrow checker will thank you. We add `FatNode::try_new_hierarchy_view`.

ss2165 · 2024-11-20T18:07:40Z

tket2 rotation lowering moved to eldarion here: https://github.com/CQCL-DEV/eldarion/pull/195
requires tket2 re-export: CQCL/tket2#697

…t-hugr-llvm-subtree

.github/workflows/ci-rs.yml

aborgna-q · 2024-11-22T09:57:43Z

.github/workflows/ci-rs.yml

+  tests-stable-llvm:
+    needs: changes
+    if: ${{ needs.changes.outputs.llvm == 'true' && github.event_name == 'push'}}


Note that llvm will always be true when triggered by a push to main (due to overrides).

We'll probably want some flag to run this on pull_requests too. Maybe we could add an override output to the changes job, and write this here.

if: ${{ ( needs.changes.outputs.llvm == 'true' && github.event_name == 'push' ) || needs.changes.outputs.override == 'true' }}

Though the logic is getting a bit muddy.

aborgna-q · 2024-11-22T09:58:38Z

.github/workflows/ci-rs.yml

+    strategy:
+      matrix:
+        llvm-version:
+          - ["14.0", "14-0"]


Are these different versions?
Can you add a comment explaining what they are?

Ah, you could also call name them instead

- version: "14.0" action: "14-0"

hugr-llvm/.gitattributes

hugr-llvm/.gitignore

hugr-llvm/README.md

hugr-llvm/pyproject.toml

hugr-llvm/poetry.lock

aborgna-q · 2024-11-22T10:14:07Z

.github/workflows/ci-rs.yml

      - name: Build benchmarks with all features
-        run: cargo bench --verbose --no-run --workspace --all-features
+        run: cargo bench --verbose --no-run --workspace --exclude hugr-llvm --all-features


Won't --all-features include hugr-llvm anyways, since it's an optional dep of hugr?

yes you're right, the excluding only makes sense for tests

hugr-llvm/CHANGELOG.md

.github/workflows/ci-rs.yml

aborgna-q · 2024-11-22T14:05:09Z

.github/workflows/ci-rs.yml

+    strategy:
+      matrix:
+        llvm-version:
+          - ["14.0", "14-0"]


Ah, you could also call name them instead

- version: "14.0" action: "14-0"

aborgna-q · 2024-11-22T14:11:09Z

.github/workflows/ci-rs.yml

+        run: cargo test --verbose  --all-features --no-run
      - name: Tests with all features
-        run: cargo test --verbose --workspace --all-features
+        run: cargo test --verbose  --all-features


This does compile hugr-llvm due to the hugr/llvm feature, it just doesn't run the dependency tests.

I'm guessing we don't need to install llvm as long as no test actually tries to access it at runtime?

yes correct

Co-authored-by: Agustín Borgna <[email protected]>

doug-q and others added 30 commits May 24, 2024 14:52

init

a44f954

Remove pin to inkwell master branch. Add basic building instructions.…

8e30350

… Add license.

feat: Emission for Call nodes

f85f2dd

Expect right in void case

554a0f6

Use build_extract_value to unpack return struct

cbc46ce

Refactor inputs

dfa0b03

Co-authored-by: doug-q <[email protected]>

Merge pull request #11 from mark-koch/feat/call

7609d88

feat: Emission for Call nodes

fix: Syntax error

c3bb2bf

Merge pull request #12 from croyzor/fix/typo

ef9d69c

fix: Syntax error

add CI

3a1fc7c

chore: Add issue-to-project.yml, enable coverage

bfd6b8e

Merge pull request #15 from CQCL/doug/ci

5962217

chore: Add issue-to-project.yml, enable coverage

ci: Fix change-filters

9249f22

They were pointing to an invalid source directory.

Merge pull request #16 from CQCL/ab/fix-change-filters

c079b7f

ci: Fix change-filters

fix: sum type tag elision logic reversed

b00683a

Merge pull request #18 from CQCL/doug/fix-sum-tag-elision

b63c619

fix: sum type tag elision logic reversed

test: add a test for sum type tags

35785e5

Merge pull request #27 from CQCL/doug/tag-test

4ae1b8a

test: add a test for sum type tags

feat: Support values

66d456e

Merge pull request #30 from CQCL/feat/func_type_ptr

aac3bfe

feat: Support `FunctionType` values

feat: add get_extern_func (#28)

2f64087

feat: lower CFGs (#26)

a87c3e2

feat: Add initial codegen extension for prelude (#29)

4b51a4c

Note that this extension is not intended to be complete, just enough to get started. We include some simplification of test infrastructure, although it is not strictly necessary. An earlier approach required these changes.

docs: fix bad grammar (#34)

1f1c633

feat: Implement lowerings for ieq,ilt_s,sub in int codegen extension (#…

8d86755

…33)

feat: Add initial float extension (#31)

fa37181

test: Add integration tests lowering guppy programs (#35)

b63ba63

Co-authored-by: Mark Koch <[email protected]>

chore: configure codecov, add some badges to README (#40)

65f686a

refactor: clean up fat.rs (#38)

1a2c642

We take the opportunity to tidy up cfg.rs a bit. `impl Copy for FatNode` will now work, and many other methods now have more appropriate lifetime constraints. The borrow checker will thank you. We add `FatNode::try_new_hierarchy_view`.

ss2165 self-assigned this Nov 15, 2024

ss2165 removed the run-ci-checks Special label to force running all checks in CI label Nov 15, 2024

fix commands

3f281d3

ss2165 force-pushed the doug/init-hugr-llvm-subtree branch from e7509de to 3f281d3 Compare November 18, 2024 15:00

ss2165 added 3 commits November 20, 2024 14:34

re-export llvm optionally from hugr

69b5fa2

Merge branch 'main' into doug/init-hugr-llvm-subtree

2c27be9

remove erroneous model dependency

377b19a

doug-q mentioned this pull request Nov 21, 2024

hugr-llvm: Export testing utilities #1673

Closed

ss2165 added 3 commits November 21, 2024 15:06

Merge commit '8045498a37b070e668b73a303f1a0316b9c2a7ba' into doug/ini…

0ef27a3

…t-hugr-llvm-subtree

end of file fixes

b8413cc

Merge branch 'main' into doug/init-hugr-llvm-subtree

4588f5f

aborgna-q reviewed Nov 22, 2024

View reviewed changes

hugr-llvm/CHANGELOG.md Show resolved Hide resolved

ss2165 added 9 commits November 22, 2024 13:04

remove redundant flags

0743764

workflow comment

770b0a5

move gitattributes

b2ba030

remove gitignore

6cb115f

add version changelog line

06d7d4d

move to workspace dep

6da08d5

remove py env files

30a019f

readme suggested changes

056c8c8

merge development.md

eaba335

ss2165 requested a review from aborgna-q November 22, 2024 13:18

aborgna-q approved these changes Nov 22, 2024

View reviewed changes

enable CI on all PRs

010f5cf

Co-authored-by: Agustín Borgna <[email protected]>

ss2165 enabled auto-merge November 22, 2024 14:33

ss2165 disabled auto-merge November 22, 2024 14:37

ss2165 merged commit 1b94d45 into main Nov 22, 2024
21 of 23 checks passed

ss2165 deleted the doug/init-hugr-llvm-subtree branch November 22, 2024 14:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: git subtree move in hugr-llvm #1601

feat: git subtree move in hugr-llvm #1601

doug-q commented Oct 21, 2024 •

edited by ss2165

Loading

ss2165 commented Nov 20, 2024 •

edited

Loading

aborgna-q Nov 22, 2024

aborgna-q Nov 22, 2024

aborgna-q Nov 22, 2024

aborgna-q Nov 22, 2024

ss2165 Nov 22, 2024

aborgna-q Nov 22, 2024

aborgna-q Nov 22, 2024

ss2165 Nov 22, 2024

feat: git subtree move in hugr-llvm #1601

feat: git subtree move in hugr-llvm #1601

Conversation

doug-q commented Oct 21, 2024 • edited by ss2165 Loading

ss2165 commented Nov 20, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

doug-q commented Oct 21, 2024 •

edited by ss2165

Loading

ss2165 commented Nov 20, 2024 •

edited

Loading